Chyrp

Comments and changes to this ticket

• 

  Alex Suraci August 29th, 2008 @ 10:55 PM

  • → Milestone changed from “2.0 rc1” to “2.0 rc2”
• 

  Alex Suraci August 30th, 2008 @ 01:21 AM

  • → State changed from “new” to “open”

  I can't reproduce this in any testing locally.

  Note that guest comments will show up to guests if they have the same IP address as the other commentor (or, in a more clear-cut case, if the comment's "user ID" is that of the visitor's user ID when they're logged in).

  In some cases the IP addresses will not be 100% accurate (e.g. a local installation can return "::1" on some systems), and will be entered into the database as 0. However, the code is set to ignore that, and will only attempt to match user IDs in such a case.

  So, I'm waiting to see what the affected rows in your database look like so I can tell what's going on.

• 

  Alex Whitman August 30th, 2008 @ 05:59 AM

  Rather than use the IP, wouldn't it be better to set a cookie containing the comment id? If you've got several users visiting the site behind a NAT'd network their IP would all be same.

• 

  Alex Suraci August 30th, 2008 @ 11:53 AM

  You're right, that would be better. I'll just store it in the session.

• 

  Repository September 1st, 2008 @ 02:23 PM

  • → State changed from “open” to “resolved”

  (from [0a83e618df461db5a1dc6aedf397251ee67fcbf7]) * Prettified some QueryBuilder code. * Store user comments in their session. [#199 state:resolved] http://github.com/vito/chyrp/com...